Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update butterflies/init.lua to solve #2987 #3086

Closed
wants to merge 5 commits into from
Closed

Update butterflies/init.lua to solve #2987 #3086

wants to merge 5 commits into from

Conversation

JoseDouglas26
Copy link
Contributor

Updated butterflies/init.lua to solve issues with on_rightclick

Updated butterflies/init.lua to solve issues with on_rightclick
@JoseDouglas26 JoseDouglas26 changed the title Update butterflies/init.lua Update butterflies/init.lua to solve #2987 Dec 22, 2023
mods/butterflies/init.lua Outdated Show resolved Hide resolved
mods/butterflies/init.lua Outdated Show resolved Hide resolved
mods/butterflies/init.lua Outdated Show resolved Hide resolved
mods/butterflies/init.lua Outdated Show resolved Hide resolved
mods/butterflies/init.lua Show resolved Hide resolved
@sfan5 sfan5 added the Bugfix label Dec 24, 2023
@JoseDouglas26 JoseDouglas26 requested a review from sfan5 December 24, 2023 13:59
@SmallJoker
Copy link
Contributor

This code looks very similar to core.item_place. Wouldn't the following code work as well?

	on_place = minetest.item_place, -- this is the default.
	-- Can be further simplified to:
	on_place = nil,
	-- Can be further simplified to:
	-- (function removed)
	
	after_place_node = function(pos, _, _, _)
		minetest.get_node_timer(pos):start(1)
	end,

@JoseDouglas26 JoseDouglas26 deleted the butterflies_on_place_change branch January 7, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants